feat: Add support gruf 2.19 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AS-AlStar
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
AS-AlStar
force-pushed
the
support-gruf-2.19
branch
2 times, most recently
from
532d9fb to
de9f594
Compare
AS-AlStar
force-pushed
the
support-gruf-2.19
branch
from
de9f594 to
084b756
Compare
arielvalentin
requested changes
Feb 17, 2024
| @@ -7,7 +7,7 @@ | |||
| module OpenTelemetry | |||
| module Instrumentation | |||
| module Gruf | |||
| VERSION = '0.1.1' | |||
| VERSION = '0.1.2' | |||
There was a problem hiding this comment.
Suggested change
| VERSION = '0.1.2' | |
| VERSION = '0.1.1' |
Our release process manages gem versions. No need to change this manually
| @@ -4,10 +4,7 @@ | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| appraise 'gruf-2.15.1' do | |||
There was a problem hiding this comment.
This means we lose test coverage for versions prior to 2.19.
Is that ok? Are you looking to drop support for older versions?
There was a problem hiding this comment.
I added the support of the last three versions of Gruf, it seems that there is no need to indicate the dependence of the GRPC version
AS-AlStar
force-pushed
the
support-gruf-2.19
branch
2 times, most recently
from
a81227d to
cb34ca9
Compare
AS-AlStar
force-pushed
the
support-gruf-2.19
branch
from
cb34ca9 to
d62bfa3
Compare
|
Please remove the following to re-enable the tests in CI: |
arielvalentin
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update appraise for gruf 2.19 and old versions