Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access rdkafka message headers with strings instead of symbols #650

Closed
wants to merge 7 commits into from
Closed

fix: access rdkafka message headers with strings instead of symbols #650

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6dc0a55
fix: access rdkafka message headers with strings instead of symbols
Ruto8 Sep 5, 2023
c942dc9
Merge branch 'main' into fix-rdkafka-deprecation-warning
arielvalentin Sep 7, 2023
b1452ba
Merge branch 'main' into fix-rdkafka-deprecation-warning
arielvalentin Sep 19, 2023
229c7ac
Merge branch 'main' into fix-rdkafka-deprecation-warning
arielvalentin Oct 28, 2023
8dba370
Merge branch 'main' into fix-rdkafka-deprecation-warning
fbogsany Nov 1, 2023
27384c2
Merge branch 'main' into fix-rdkafka-deprecation-warning
kaylareopelle Nov 6, 2023
112f119
Merge branch 'main' into fix-rdkafka-deprecation-warning
arielvalentin Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/patches/consumer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def each
message_key = extract_message_key(message.key)
attributes['messaging.kafka.message_key'] = message_key if message_key

parent_context = OpenTelemetry.propagation.extract(message.headers, getter: OpenTelemetry::Common::Propagation.symbol_key_getter)
parent_context = OpenTelemetry.propagation.extract(message.headers)
span_context = OpenTelemetry::Trace.current_span(parent_context).context
links = [OpenTelemetry::Trace::Link.new(span_context)] if span_context.valid?

Expand All @@ -47,7 +47,7 @@ def each_batch(max_items: 100, bytes_threshold: Float::INFINITY, timeout_ms: 250
}

links = messages.map do |message|
trace_context = OpenTelemetry.propagation.extract(message.headers, getter: OpenTelemetry::Common::Propagation.symbol_key_getter)
trace_context = OpenTelemetry.propagation.extract(message.headers)
span_context = OpenTelemetry::Trace.current_span(trace_context).context
OpenTelemetry::Trace::Link.new(span_context) if span_context.valid?
end
Expand Down