convert to rspec

open-telemetry · Aug 5, 2024 · e8fa575 · e8fa575
1 parent 7bb9db0
commit e8fa575
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/instrumentation/pg/test/fixtures/sql_table_name.json b/instrumentation/pg/test/fixtures/sql_table_name.json
@@ -13,7 +13,7 @@
     },
     {
       "name": "insert_into",
-      "sql": "INSERT INTO table_name (column1, column2) VALUES (value1, value2)"
+      "sql": "INSERT INTO test_table (column1, column2) VALUES (value1, value2)"
     },
     {
       "name": "update",

diff --git a/instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb b/instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb
@@ -384,10 +384,10 @@ def self.load_fixture
         name = test_case['name']
         query = test_case['sql']
 
-        define_method(:"test_sql_table_name_#{name}") do
+        it "returns the table name for #{name}" do
           table_name = client.send(:collection_name, query)
 
-          assert_equal('test_table', table_name) # TODO: use an expected name from fixtures or update fixtures to always use "table_name"
+          expect(table_name).must_equal('test_table')
         end
       end
     end