psycopg2-binary support #1422
Closed
psycopg2-binary support #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
suggested changes
Dec 31, 2024
|
Oh, this is 2 years old. 😢 Still valid tho. |
xrmx
requested changes
Dec 31, 2024
| @@ -13,4 +13,4 @@ | |||
| # limitations under the License. | |||
|
|
|||
|
|
|||
| _instruments = ("psycopg2 >= 2.7.3.1",) | |||
| _instruments = (("psycopg2 >= 2.7.3.1", "psycopg2-binary >= 2.7.3.1"),) | |||
There was a problem hiding this comment.
Suggested change
| _instruments = (("psycopg2 >= 2.7.3.1", "psycopg2-binary >= 2.7.3.1"),) | |
| _instruments = ("psycopg2 >= 2.7.3.1", "psycopg2-binary >= 2.7.3.1") |
This is what the kafka-python is doing, please take a look at opentelemetry-instrumentation-kafka-python/pyproject.toml, with that updated you should be able to drop the dependencies,py changes.
There was a problem hiding this comment.
I've done the minimal implementation here #3186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by this comment. I changed the idea slightly to OR inner tuples, it seemed to be easier to do but let me know what do you think about it.
Fixes #610
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.