Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collectorSelector field from TA CRD #3039

Merged

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Jun 14, 2024

Doing this as per the decision made in #2422 (comment). We're going to use a label to manage this relationship instead.

On a separate note, I'd like to give the TargetAllocator builder a different Params struct, so we can more clearly indicate this relationship. That's a more involved change, though, and I'll make it separately.

@swiatekm swiatekm requested a review from a team June 14, 2024 10:12
@swiatekm swiatekm force-pushed the feat/drop-selector-from-ta-crd branch from f5bdf1a to ba3cc54 Compare June 14, 2024 10:12
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 14, 2024
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about the params change. I was thinking we would even make the CR being reconciled a generic type for the params struct i.e. type Params[T client.Object] struct or something like that... client.Object probably isn't right though

@swiatekm
Copy link
Contributor Author

I agree about the params change. I was thinking we would even make the CR being reconciled a generic type for the params struct i.e. type Params[T client.Object] struct or something like that... client.Object probably isn't right though

I don't think that's enough in this case. What I actually want is to have Params contain a TargetAllocator struct and a slice of Collectors connected to it.

Actually making the builder code more generic isn't that difficult - I'll submit the change I have very soon.

@swiatekm swiatekm merged commit c490d80 into open-telemetry:main Jun 15, 2024
33 of 34 checks passed
@swiatekm swiatekm deleted the feat/drop-selector-from-ta-crd branch June 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants