[charts/opentelemetry-demo] Use helm namespace for service.namespace in default helm values #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in default helm values Currently, service.namespace always gets set to opentelemetry-demo. This results in confusing metric labels when deploying the chart into a namespace that is not opentelemetry-demo. With this change, service.namespace will be set to the namespace the chart is deployed in.
|
|
The demo already follows the semantic conventions, which state that |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closing per #1482 (comment), as the current setup is actually intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, service.namespace always gets set to opentelemetry-demo.
This results in confusing metric labels when deploying the chart into a namespace that is not opentelemetry-demo. With this change, service.namespace will be set to the namespace the chart is deployed in.
Should I also bump the chart patch or minor version here?