-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup code attributes in Elixir macros #808
Open
btkostner
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
btkostner:code-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f02834
feat: setup code attributes in Elixir macros
btkostner 1a4fff2
fix otel tests
btkostner 3e34ac3
add another tracer macro test
btkostner 699f6d7
fix mix formatting on tests
btkostner d755763
fix angry line number assert test
btkostner 543b8c0
remove Elixir. prefix from namespace
btkostner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
defmodule OpenTelemetry.Attributes do | ||
@moduledoc """ | ||
This module contains utility functions for span attributes. | ||
|
||
Elixir has built in variables like `__ENV__` and `__CALLER__` that can be used to generate | ||
span attributes like `code.function`, `code.lineno`, and `code.namespace` either during runtime | ||
or compile time. This module provides a function to generate these attributes from a `t:Macro.Env` | ||
struct. | ||
|
||
For more information, view the [OpenTelemetry Semantic Conventions](OSC). | ||
|
||
[OSC]: https://opentelemetry.io/docs/specs/semconv/attributes-registry | ||
""" | ||
|
||
@code_filepath :"code.filepath" | ||
@code_function :"code.function" | ||
@code_lineno :"code.lineno" | ||
@code_namespace :"code.namespace" | ||
|
||
@doc """ | ||
A function used to generate attributes from a `t:Macro.Env` struct. | ||
|
||
This function is used to generate span attributes like `code.function`, `code.lineno`, and | ||
`code.namespace` from a `__CALLER__` variable during compile time or a `__ENV__` variable | ||
run time. | ||
|
||
## Usage | ||
|
||
# During run time | ||
def my_function() do | ||
OpenTelemetry.Attributes.from_macro_env(__ENV__) | ||
end | ||
|
||
iex> my_function() | ||
%{code_function: "my_function/0", ...} | ||
|
||
# During compile time in a macro | ||
defmacro my_macro() do | ||
attributes = | ||
__CALLER__ | ||
|> OpenTelemetry.Attributes.from_macro_env() | ||
|> Macro.escape() | ||
|
||
quote do | ||
unquote(attributes) | ||
end | ||
end | ||
|
||
def my_other_function() do | ||
my_macro() | ||
end | ||
|
||
iex> my_macro() | ||
%{code_function: "my_other_function/0", ...} | ||
|
||
""" | ||
@spec from_macro_env(Macro.Env.t()) :: OpenTelemetry.attributes_map() | ||
def from_macro_env(%Macro.Env{} = env) do | ||
function_arty = | ||
case env.function do | ||
{func_name, func_arity} -> "#{func_name}/#{func_arity}" | ||
nil -> nil | ||
end | ||
|
||
%{ | ||
@code_function => function_arty, | ||
@code_namespace => inspect(env.module), | ||
@code_filepath => env.file, | ||
@code_lineno => env.line | ||
} | ||
|> Enum.reject(fn {_k, v} -> is_nil(v) end) | ||
|> Map.new() | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this public but undocumented. Not sure if we want to document and make it part of the public API