Extract reporter data generation, and use pdata #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked on open-telemetry/opentelemetry-collector#11706, since pdata currently uses a map for the attribute table. |
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
3d87afb to
3b36dab
Compare
|
@open-telemetry/ebpf-profiler-approvers this change would greatly reduce the size of the OTLP and Collector reporters, as both would use pdata rather than OTLP and pdata. |
florianl
reviewed
Nov 29, 2024
Co-authored-by: Florian Lehner <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
d936928 to
d4cf5d9
Compare
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
d4cf5d9 to
76589ca
Compare
|
Here is a version of devfiler with OTel Profiling v1.4.0 support: or https://upload.elastic.co/d/b55a069766c48b8c0d4c0f2b854b0e846ee4deaea75596b68a8e1d88172dd0ca |
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
13500da to
76e623a
Compare
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
76e623a to
c2737da
Compare
|
@open-telemetry/ebpf-profiler-approvers this is ready for review. |
This comment was marked as resolved.
This comment was marked as resolved.
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
128b9ea to
d1c49f2
Compare
christos68k
reviewed
Dec 4, 2024
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
florianl
reviewed
Dec 5, 2024
florianl
approved these changes
Dec 6, 2024
christos68k
approved these changes
Dec 6, 2024
Co-authored-by: Christos Kalkanis <[email protected]>
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
6 times, most recently
from
6d451a4 to
bd69069
Compare
dmathieu
force-pushed
the
otlp-reporter-pdata
branch
from
bd69069 to
e1ef19b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to help reduce the code repetition in #208
It extracts the data generation into its own internal module, and switches from OTLP to pdata (which is an OTLP abstraction), so both reporters can rely on the same data generator.