Deprecate receivertest.NewNopFactoryForType #11993
Merged
+28
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
dep-component-type
branch
from
fd361da to
5c6baf6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11993 +/- ##
==========================================
- Coverage 91.70% 91.69% -0.02%
==========================================
Files 455 455
Lines 24053 24053
==========================================
- Hits 22058 22055 -3
- Misses 1625 1627 +2
- Partials 370 371 +1 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not offer same for any other component test package, and also this is only used in one place across core and contrib. For consistency and limiting the public API, deprecate this functionality.