[exporterqueue] Implement blocking queue #11951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
sfc-gh-sili
force-pushed
the
sili-batching
branch
from
ede52ac to
bcd3fe8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11951 +/- ##
==========================================
- Coverage 91.70% 91.69% -0.01%
==========================================
Files 447 448 +1
Lines 23728 23793 +65
==========================================
+ Hits 21759 21817 +58
- Misses 1600 1606 +6
- Partials 369 370 +1 ☔ View full report in Codecov by Sentry. |
|
@sfc-gh-sili please rebase and look at the failing CI |
sfc-gh-sili
force-pushed
the
sili-batching
branch
2 times, most recently
from
7ea3462 to
0448db0
Compare
sfc-gh-sili
force-pushed
the
sili-batching
branch
from
301d1e0 to
05cec89
Compare
sfc-gh-sili
force-pushed
the
sili-batching
branch
from
3028f40 to
946ba78
Compare
dmitryax
reviewed
Jan 6, 2025
| usePullingBasedExporterQueueBatcher.IsEnabled() && be.BatcherCfg.Enabled && !be.queueCfg.Enabled { | ||
| if usePullingBasedExporterQueueBatcher.IsEnabled() && be.BatcherCfg.Enabled && !be.queueCfg.Enabled { | ||
| be.queueFactory = exporterqueue.NewBlockingMemoryQueue[internal.Request]() | ||
| be.queueCfg.QueueSize = 20 |
There was a problem hiding this comment.
Why do we need to set it to 20?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
batch_senderif the feature gateUsePullingBasedExporterQueueBatcheris on.Link to tracking issue
#8122
#10368
Testing
Documentation