-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add more Windows versions for testing #37025
base: main
Are you sure you want to change the base?
[chore] add more Windows versions for testing #37025
Conversation
@pjanotti would you please review? Some CI failures are happening for both 2022 and 2025. I also see main failing. |
Group |
|
Fix for |
#36923 fixes the other failures for |
The error in |
@CodePrometheus apply the following patch to your change to fix the diff --git a/exporter/prometheusremotewriteexporter/exporter_concurrency_test.go b/exporter/prometheusremotewriteexporter/exporter_concurrency_test.go
index 689cbcf7b9..14fc6364c4 100644
--- a/exporter/prometheusremotewriteexporter/exporter_concurrency_test.go
+++ b/exporter/prometheusremotewriteexporter/exporter_concurrency_test.go
@@ -52,6 +52,11 @@ func Test_PushMetricsConcurrent(t *testing.T) {
t.Fatal(err)
}
assert.NotNil(t, body)
+ if len(body) == 0 {
+ // No content, nothing to do. The request is just checking that the server is up.
+ return
+ }
+
// Receives the http requests and unzip, unmarshalls, and extracts TimeSeries
assert.Equal(t, "0.1.0", r.Header.Get("X-Prometheus-Remote-Write-Version"))
assert.Equal(t, "snappy", r.Header.Get("Content-Encoding"))
@@ -124,6 +129,12 @@ func Test_PushMetricsConcurrent(t *testing.T) {
require.NoError(t, prwe.Shutdown(ctx))
}()
+ // Ensure that the test server is up before making the requests
+ assert.EventuallyWithT(t, func(c *assert.CollectT) {
+ _, checkRequestErr := http.Get(server.URL)
+ assert.NoError(c, checkRequestErr)
+ }, 5*time.Second, 100*time.Millisecond)
+
var wg sync.WaitGroup
wg.Add(n)
for _, m := range ms { |
537492c
to
c855d73
Compare
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [windows-2022, windows-2025] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this one is fine to use windows-latest since it is building the binary, we should be fine with windows-latest
- it also breaks because it tries to upload two artifacts with the same name.
@CodePrometheus (or someone with the rights) could you please merge latest main to clean up the CI failures that were unrelated to this PR? |
It seems that my suggestion at #37025 (comment) wasn't enough to fix the concurrency issue on Windows 2025... 🤔 |
Description
Link to tracking issue
Fixes #37024
Testing
Documentation