[chore][processor/deltatocumulative] Optimize exponential histogram m… #37010
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
commented
Jan 2, 2025
| @@ -26,10 +26,10 @@ func Merge(arel, brel Buckets) { | |||
| size := up - lo | |||
|
|
|||
| counts := pcommon.NewUInt64Slice() | |||
There was a problem hiding this comment.
[For reviewers] There is also some opportunity to reduce allocations a bit more if arel is already at the required capacity and the lower bound of the final result is the arel's lower bound but I haven't done that yet since that might require some discussion over readability vs performance.
sh0rez
approved these changes
Jan 3, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
approved these changes
Jan 19, 2025
| @@ -26,10 +26,10 @@ func Merge(arel, brel Buckets) { | |||
| size := up - lo | |||
|
|
|||
| counts := pcommon.NewUInt64Slice() | |||
| counts.Append(make([]uint64, size-counts.Len())...) | |||
| counts.EnsureCapacity(size) | |||
There was a problem hiding this comment.
How to reduce allocations by this optimization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the merge of exponential histogram a bit and also reduces allocations.
Link to tracking issue
N/A
Testing
N/A
Documentation
N/A