-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: adding Erog38 as a codeowner of telemetrygen #37003
base: main
Are you sure you want to change the base?
[chore]: adding Erog38 as a codeowner of telemetrygen #37003
Conversation
CLA done and we should be good 😄 |
Thank you for volunteering to help. Please open an issue to become a member here: https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E You can count me as sponsor. You need someone else to sponsor you from a different organization. Please also attend to the CI, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! I'd love to be the sponsor too!
Thank you both! I've submitted that request here: open-telemetry/community#2500 and will attend to the CI here. |
I've run |
Running |
…er' into chore/pgore-telemetrygen-codeowner
@codeboten can you take a look? @Erog38 Thanks for offering to do this work, it's great to have you on :) |
Thanks @mx-psi! It's good to be able to lend a hand. I hope to get more involved seeing how things go here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37003 +/- ##
==========================================
- Coverage 79.62% 79.62% -0.01%
==========================================
Files 2224 2224
Lines 210393 210393
==========================================
- Hits 167534 167530 -4
- Misses 37246 37248 +2
- Partials 5613 5615 +2 ☔ View full report in Codecov by Sentry. |
Description
Adds me as a codeowner to telemetrygen to manage issue #36984 and it's API stability.
I have clearance from my organization to take this on as part of my regular duties as needed.