Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: adding Erog38 as a codeowner of telemetrygen #37003

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Erog38
Copy link

@Erog38 Erog38 commented Dec 31, 2024

Description

Adds me as a codeowner to telemetrygen to manage issue #36984 and it's API stability.

I have clearance from my organization to take this on as part of my regular duties as needed.

@Erog38 Erog38 requested review from mx-psi, codeboten and a team as code owners December 31, 2024 21:08
Copy link

linux-foundation-easycla bot commented Dec 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Dec 31, 2024
@Erog38
Copy link
Author

Erog38 commented Dec 31, 2024

@atoulme in regards to #36984 , I'm happy to take this and own it, I just need to figure out the CLA process here and likely need to navigate becoming a corporate contributor. 😞

@Erog38
Copy link
Author

Erog38 commented Dec 31, 2024

CLA done and we should be good 😄

@atoulme
Copy link
Contributor

atoulme commented Dec 31, 2024

Thank you for volunteering to help.

Please open an issue to become a member here: https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E

You can count me as sponsor. You need someone else to sponsor you from a different organization.

Please also attend to the CI, run make generate

Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! I'd love to be the sponsor too!

@Erog38 Erog38 changed the title chore: adding Erog38 as a codeowner of telemetrygen [chore]: adding Erog38 as a codeowner of telemetrygen Jan 3, 2025
@Erog38
Copy link
Author

Erog38 commented Jan 3, 2025

Thank you both! I've submitted that request here: open-telemetry/community#2500 and will attend to the CI here.

@Erog38
Copy link
Author

Erog38 commented Jan 6, 2025

I've run make generate and I'm not seeing any changes here 😅 I'm kicking off CI again with a main merge and seeing if it'll pass now that I'm a member of the org.

@Erog38
Copy link
Author

Erog38 commented Jan 7, 2025

Running make gengithub locally gives me a whole list of people that need added compared to the message in the CI. I'm a bit lost here on what's happening but will dig in tomorrow.

@fatsheep9146 fatsheep9146 added the ready to merge Code review completed; ready to merge by maintainers label Jan 7, 2025
@mx-psi
Copy link
Member

mx-psi commented Jan 7, 2025

@codeboten can you take a look?

@Erog38 Thanks for offering to do this work, it's great to have you on :)

@Erog38
Copy link
Author

Erog38 commented Jan 7, 2025

Thanks @mx-psi! It's good to be able to lend a hand. I hope to get more involved seeing how things go here.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (dac7ceb) to head (7ce8d3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37003      +/-   ##
==========================================
- Coverage   79.62%   79.62%   -0.01%     
==========================================
  Files        2224     2224              
  Lines      210393   210393              
==========================================
- Hits       167534   167530       -4     
- Misses      37246    37248       +2     
- Partials     5613     5615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants