Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/netflow] Netflow receiver implementation - PR 2 #36865
base: main
Are you sure you want to change the base?
[receiver/netflow] Netflow receiver implementation - PR 2 #36865
Changes from 18 commits
f7ff90b
9871936
09a91d1
26d5aec
64acc94
658c414
0a50dbb
dd6a006
363f93b
3854269
0fe206e
d7c0782
b343ab4
f504466
d31a81e
8d07a6a
f7b1512
33d0cee
5e178ac
ebfa73d
86701b9
52bca59
edbbbc0
d68e826
053543c
169373f
5cf7625
10fc878
2281a06
54d8b60
d2c1c1f
41b68a2
7dbde9b
b33920b
12e8425
77ec06a
a1f6422
c738398
ccf6e7c
c090043
3ef5c92
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks like metadata on the log to me. Instead of creating this struct, could we create a
plog.LogRecord
and set these values as attributes using the corresponding semconv key for each value? We can probably use the network semantic conventions here. I'm having trouble linking to the Go registry copy of the docs, but you can use thego.opentelemetry.io/collector/semconv
module to get constants for these, as seen here.For the timestamps, we could just set those on the log record. I believe the body will be empty since the incoming messages don't seem to include any kind of equivalent arbitrary-text field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug into it some more and I see that the network semconv isn't necessarily a 1:1 fit here. I think we should do as much as we can, and we can create attributes for the pieces that don't fit so long as they're documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented here