Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Send metrics origin when using v2 client #32713

Closed
wants to merge 3 commits into from
Closed

[exporter/datadog] Send metrics origin when using v2 client #32713

wants to merge 3 commits into from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 26, 2024 •
edited
Loading

Sends metrics origin when using metrics v2 client.

We need to work around limitations on datadog-api-client-go

@github-actions github-actions bot added the exporter/datadog Datadog components label Apr 26, 2024
songy23
songy23 reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a feature gate? What's the downside of always sending metrics origin?

@mx-psi mx-psi force-pushed the mx-psi/metrics-origin branch from 390165e to dfbda01 Compare May 6, 2024 15:45
@mx-psi mx-psi changed the title [exporter/datadog] Add feature gate to send metrics origin [exporter/datadog] Send metrics origin when using v2 client May 6, 2024
@mx-psi
Copy link
Member Author

mx-psi commented May 6, 2024

Why do we need a feature gate? What's the downside of always sending metrics origin?

Checked with the relevant internal team, we can send without a feature gate.

@mx-psi mx-psi marked this pull request as ready for review May 6, 2024 15:47
@mx-psi mx-psi requested review from a team and crobert-1 May 6, 2024 15:47
songy23
songy23 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @roxelo

crobert-1
crobert-1 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a changelog?

exporter/datadogexporter/internal/metrics/consumer.go Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented May 8, 2024

Should this have a changelog?

Probably, I am waiting on @roxelo's review to decide on this :)

roxelo
roxelo approved these changes May 8, 2024
View reviewed changes
Copy link

@roxelo roxelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

songy23
songy23 reviewed May 10, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 25, 2024
@github-actions github-actions bot removed the Stale label May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 11, 2024
@mx-psi mx-psi removed the Stale label Jun 11, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jun 11, 2024

Waiting on internal review

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 26, 2024
@github-actions github-actions bot requested a review from ankitpatel96 June 26, 2024 09:10
@songy23 songy23 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 11, 2024
@mx-psi mx-psi removed the Stale label Jul 11, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jan 16, 2025

Closing in favor of DataDog/datadog-agent/pull/32974

@mx-psi mx-psi closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 left review comments

@crobert-1 crobert-1 crobert-1 approved these changes

@roxelo roxelo roxelo approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

Assignees

@djaglowski djaglowski

Labels
exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mx-psi @songy23 @roxelo @crobert-1 @djaglowski