feat: executor to manage its own networks #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Since the networks are being created lazily - the first injection (and injections after cleanup) will have to wait for the creation of all networks that don't exist, slowing down a cold-start. Might be better to do on server start when possible? Did we do any benchmarking?
Meldiron
approved these changes
Aug 28, 2024
abnegate
approved these changes
Aug 28, 2024
abnegate
reviewed
Aug 28, 2024
byawitz
reviewed
Aug 28, 2024
app/http.php
Outdated
| try { | ||
| $orchestration->remove($container->getId(), true); | ||
|
|
||
| $activeRuntimeId = $container->getName(); | ||
|
|
||
| if (!$activeRuntimes->exists($activeRuntimeId)) { | ||
| if ($activeRuntimes->exists($activeRuntimeId)) { |
There was a problem hiding this comment.
Shouldn't we try to remove in any case? if it's an orphan function for example.
.github/workflows/tests.yml
Outdated
| @@ -29,5 +29,5 @@ jobs: | |||
|
|
|||
| - name: Run Tests | |||
| run: | | |||
| docker run --rm -v $PWD:/app --network openruntimes-runtimes -w /app phpswoole/swoole:4.8.12-php8.0-alpine sh -c \ | |||
| docker run --rm -v $PWD:/app --network runtimes-1 -w /app phpswoole/swoole:4.8.12-php8.0-alpine sh -c \ | |||
There was a problem hiding this comment.
Not critical, Is it worth changing to phpswoole/swoole:5.1.2-php8.3-alpine to match the executor PHP version
feat: adjusting table size
feat: getting executor name
christyjacob4
commented
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.