-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fleet-level task #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29d336f
to
3b21058
Compare
Yadunund
requested changes
Jan 15, 2024
Yadunund
approved these changes
Jan 16, 2024
Yadunund
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format your code to satisfy the linter?
@cwrx777 suggest to run
|
Yadunund
previously approved these changes
Jan 16, 2024
@cwrx777 can you make sure all your commits are signed? https://docs.github.com/articles/about-gpg/ |
Signed-off-by: Charly Wu <[email protected]>
Signed-off-by: Charly Wu <[email protected]>
Signed-off-by: Charly Wu <[email protected]>
Signed-off-by: Charly Wu <[email protected]>
14f6b35
to
ec30d77
Compare
Signed-off-by: Charly Wu <[email protected]>
ec30d77
to
e8019c4
Compare
45d9872
to
e82e23b
Compare
Yadunund
approved these changes
Jan 26, 2024
Yadunund
added a commit
that referenced
this pull request
Jan 29, 2024
* update task request to include fleet_name for fleet-level task Signed-off-by: Charly Wu <[email protected]> * added DCO commit. Signed-off-by: Charly Wu <[email protected]> * simplify logic for populating request['fleet_name'] Signed-off-by: Charly Wu <[email protected]> * remove extra whitespaces. Signed-off-by: Charly Wu <[email protected]> * remove trailing whitespace. Signed-off-by: Charly Wu <[email protected]> --------- Signed-off-by: Charly Wu <[email protected]> Co-authored-by: Yadunund <[email protected]>
Merged
Yadunund
added a commit
that referenced
this pull request
Jan 29, 2024
* Support fleet-level task (#201) * update task request to include fleet_name for fleet-level task Signed-off-by: Charly Wu <[email protected]> * added DCO commit. Signed-off-by: Charly Wu <[email protected]> * simplify logic for populating request['fleet_name'] Signed-off-by: Charly Wu <[email protected]> * remove extra whitespaces. Signed-off-by: Charly Wu <[email protected]> * remove trailing whitespace. Signed-off-by: Charly Wu <[email protected]> --------- Signed-off-by: Charly Wu <[email protected]> Co-authored-by: Yadunund <[email protected]> * Update CI to rolling on main (#208) * Update CI to rolling Signed-off-by: Yadunund <[email protected]> * Address all flake8 and pep257 errors Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Set CI to iron Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Charly Wu <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: cwrx777 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scripts to specify fleet_name in task requests.
This PR depends on: