Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch64 support #2010

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add loongarch64 support #2010

merged 1 commit into from
Dec 10, 2024

Conversation

zhaixiaojuan
Copy link
Contributor

This PR does the following:
Add loongarch64 support in CMakeLists.txt and src/common/common.c

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this platform, @zhaixiaojuan . IMO the PR should also contain a suitable entry in the PLATFORM.md file, at least listing it in the proper tier, ideally also providing explanatory pointers to the platform and the software it supports (Linux distro, e.g.). Final question: Are you willing to serve as a contact for possible future questions regarding OQS issues on this platform? I'm asking as I have 0 experience/exposure to this platform so far and thus could not do that.

@zhaixiaojuan
Copy link
Contributor Author

Final question: Are you willing to serve as a contact for possible future questions regarding OQS issues on this platform? I'm asking as I have 0 experience/exposure to this platform so far and thus could not do that.

I am happy to accept this, it is my honor. I will continue to improve liboqs on the LoongArch platform and improve its tier.

@baentsch baentsch requested a review from a team December 9, 2024 15:36
@dstebila
Copy link
Member

dstebila commented Dec 9, 2024

Thanks for the contribution! I've triggered the CI tests. @zhaixiaojuan would you be able to follow the instructions at https://github.com/open-quantum-safe/liboqs/pull/2010/checks?check_run_id=34128510566 to do the Developer Certificate of Origin sign-off?

Will hold off on merging this until after 0.12.0 is released.

Signed-off-by: zhaixiaojuan <[email protected]>
@zhaixiaojuan
Copy link
Contributor Author

Thank you very much. When is 0.12.0 expected to be released?

@dstebila dstebila merged commit ee0da46 into open-quantum-safe:main Dec 10, 2024
3 checks passed
@dstebila
Copy link
Member

Thank you very much. When is 0.12.0 expected to be released?

It has just been released. And now I've landed this PR on the main branch after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants