manager: smoother fetch items (fixes #7463) #7464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutugiii
commented
May 22, 2024
| @@ -137,7 +137,9 @@ export class SyncService { | |||
| } | |||
|
|
|||
| replicatorsArrayWithTags(items, type: 'pull' | 'push', planetField: 'local' | 'parent') { | |||
| return this.stateService.getCouchState('tags', planetField).pipe(map(tags => this.createReplicatorsArray(items, type, tags))); | |||
| return this.stateService.getCouchState('tags', planetField).pipe( | |||
| take(1), | |||
There was a problem hiding this comment.
currently taking only the first observable in the replicators array.
Could compare the 2 received and then take it only if they are the same.
dogi
approved these changes
May 22, 2024
dogi
changed the title
dogi
deleted the
7463-double-popups-across-courses-resources-and-manager-fetc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7463
In the manager fetch items, we have a situation where the popups open twice on page initialization.
Resolve it to only open one.