-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planet Tutorial Wording and Clarification Improvements for Step 4 (fixes #2519) #2521
Closed
johnmdrake1
wants to merge
4
commits into
open-learning-exchange:master
from
johnmdrake1:step4-planet-wordingfix-johnmdrake1
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
df0cb11
Planet Tutorial Wording and Clarification Improvements for Step 4 (fi…
johnmdrake1 c8326a5
Fixed spelling of preferred as per @ChiragAwale request
johnmdrake1 e9355a6
Fixed spelling of preferred, somehow had a spelling mistake again but…
johnmdrake1 eccd877
Made clarification about screenshots portion of question.
johnmdrake1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmdrake1 can you explain this statement? Are you trying to say you should upload screenshot or saying not to use gitter if you are not familiar with that feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was taking the planet course, there was nowhere I saw in the free response feedback question to upload a photo or screenshot, I checked the toolbar at the top of the text entry field for an attachment button and didn't see one unless I missed it. I personally uploaded my screenshots to Imgur, and made a private Imgur link to my album which I put in my answer to question 12. Not everyone may know how to use screenshot sharing websites such as Imgur, so I was saying use Gitter if you don't know another way. If there is a preferred image hosting site OLE would like Virtual Interns to use for that question that should go there instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Immrssa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leomaxi comes up, if that's your tag my apologies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmmrssa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lillyxxx completely agreed. Thoughts @lmmrssa So I can get this issue and pull request sorted out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmdrake1 @lillyxxx as mentioned planet does not have way to upload image on exam. If question is confusing we can change the question which is not part of this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in my opinion that is what should be done. On my end, should I take out my addition about how to upload images on the exam, and the Planet team can change the question in the appropriate repository? @lmmrssa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmmrssa is this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see most recent commit)