Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressNL - autofill unhappy flow #5006

Closed
robinmolen opened this issue Jan 8, 2025 · 1 comment · Fixed by open-formulieren/types#65 or open-formulieren/formio-builder#206 · May be fixed by open-formulieren/open-forms-sdk#775 or #5022
Closed

Comments

@robinmolen
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

This ticket will be picked-up as part of #4431

In the current autofill functionality the option to manual editing the streetname and city is missing. This should be possible, incase that the autofill fails (service offline, invalid address).

The desired working of the autofill is as follows:

  1. Only show postalcode, number and addition as editable fields
  2. Fill in values: Resolves to an address? Go to 3a. No address? Go to 3b.
    3a. Show read-only woonplaats and street
    3b. Show editable woonplaats and street fields
  3. Change the postalcode, etc. values -> go to 2

Added value / Toegevoegde waarde

This ensures that users can use the AddressNL field, even if the autofill fails

Aanvullende opmerkingen / Additional context

See #2566 (comment) and #4431 (comment) for more information/context

@robinmolen robinmolen added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jan 8, 2025
@joeribekker
Copy link
Contributor

joeribekker commented Jan 13, 2025

Streetname and City fields should ALSO be mandatory IF the component is mandatory and the fields are displayed

@joeribekker joeribekker added owner: dimpact and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 13, 2025
@robinmolen robinmolen moved this from Todo to In Progress in Development Jan 14, 2025
@robinmolen robinmolen assigned vaszig and unassigned robinmolen Jan 15, 2025
vaszig added a commit to open-formulieren/types that referenced this issue Jan 16, 2025
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 16, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name besed on the postcode nd husenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
somthing goes wrong with the API call.
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Jan 16, 2025
… and preview in the builder according to autoPopulated field
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 17, 2025
…nually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name besed on the postcode nd housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 17, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 17, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit that referenced this issue Jan 17, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required.
@vaszig vaszig moved this from In Progress to Implemented in Development Jan 17, 2025
@vaszig vaszig moved this from Implemented to In Progress in Development Jan 20, 2025
vaszig added a commit to open-formulieren/formio-builder that referenced this issue Jan 21, 2025
… and preview in the builder according to autoPopulated field
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
@vaszig vaszig mentioned this issue Jan 21, 2025
2 tasks
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit that referenced this issue Jan 22, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required.
vaszig added a commit that referenced this issue Jan 22, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required.
vaszig added a commit that referenced this issue Jan 23, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required.
vaszig added a commit that referenced this issue Jan 23, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required. Additionally,
the postcode and housenumber fields are always both required or none.
vaszig added a commit that referenced this issue Jan 23, 2025
…eetname and city

Updated street name and city serializer fields in order to be able to
require these fields in case the component is required.
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 23, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 23, 2025
…ually fill in city and streetname

Until now the addressNL component would retrieve the city and street
name based on the postcode and housenumber. These fields were always
read-only but now we want to be able to fill in city and street name if
something goes wrong with the API call.
@vaszig vaszig moved this from In Progress to Implemented in Development Jan 23, 2025
@vaszig vaszig moved this from Implemented to In Progress in Development Jan 23, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Jan 24, 2025
@vaszig vaszig moved this from Done to In Progress in Development Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment