Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressNL - styling update #5003

Closed
2 tasks done
robinmolen opened this issue Jan 8, 2025 · 2 comments · Fixed by open-formulieren/open-forms-sdk#778
Closed
2 tasks done

AddressNL - styling update #5003

robinmolen opened this issue Jan 8, 2025 · 2 comments · Fixed by open-formulieren/open-forms-sdk#778

Comments

@robinmolen
Copy link
Contributor

robinmolen commented Jan 8, 2025

Thema / Theme

Frontend

Omschrijving / Description

This ticket will be picked-up as part of #4431, and describes some small styling changes for the AddressNL component

  • Remove the italic styling from the <address> html tag (in the submission overview. I think this is the <address> in getValueAsString(...))
  • Remove the "required" asterisk mark from the component. Only the individual fields should have this mark (if they are required)
    (If the AddressNL component is marked required, then (only) the postcode and houseNumber fields should be required. Otherwise everything is optional)

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response

@robinmolen robinmolen added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jan 8, 2025
@joeribekker joeribekker added this to the Release 3.1.0 milestone Jan 13, 2025
@joeribekker
Copy link
Contributor

Regarding fields being required/optional we keep the current behaviour except we remove the asterisk from the component label and remove the label altogether. (we did something similar in the content component)

required
AddressNL
Postal code*
Housenumber*
Addition

optional
AddressNL
Postal code
Housenumber
Addition

Even when optional, when you fill in Postal code, it will show housenumber is then required.

@vaszig vaszig assigned vaszig and unassigned robinmolen Jan 17, 2025
@joeribekker joeribekker added owner: dimpact and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 20, 2025
@vaszig vaszig moved this from Todo to In Progress in Development Jan 20, 2025
@vaszig vaszig moved this from In Progress to Implemented in Development Jan 21, 2025
@vaszig
Copy link
Contributor

vaszig commented Jan 21, 2025

Concerning the first comment, in issue #5006 we have decided to mark as required every field that it is required. So, this handles the styling issue (italic) and the label of the component (not marked as required if so).

vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 21, 2025
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants