Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#5003] Update styling in addressNL component #778

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 21, 2025

Copy link

codecov bot commented Jan 21, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (da9810b) to head (be80276).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   82.19%   82.17%   -0.03%     
==========================================
  Files         241      241              
  Lines        4887     4887              
  Branches     1319     1325       +6     
==========================================
- Hits         4017     4016       -1     
- Misses        835      836       +1     
  Partials       35       35              
Flag Coverage Δ
storybook 75.14% <ø> (-0.03%) ⬇️
vitest 60.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig changed the title [OF#5003] Updated styling in addressNL component [OF#5003] Update styling in addressNL component Jan 21, 2025
@vaszig vaszig marked this pull request as draft January 21, 2025 09:29
@vaszig vaszig force-pushed the of-5003/addressNL-styling-update branch from 2ace4a8 to fc8bd0e Compare January 21, 2025 10:16
@vaszig vaszig marked this pull request as ready for review January 21, 2025 10:16
@vaszig vaszig force-pushed the of-5003/addressNL-styling-update branch from fc8bd0e to be80276 Compare January 21, 2025 10:17
@vaszig vaszig requested a review from robinmolen January 21, 2025 12:22
Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good!

The temporary solution for the asterisk looks indeed fine for now 👍

@robinmolen robinmolen merged commit be827d9 into main Jan 22, 2025
16 of 17 checks passed
@robinmolen robinmolen deleted the of-5003/addressNL-styling-update branch January 22, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressNL - styling update
2 participants