Skip to content

Commit

Permalink
Removed Python 3.9 from test environment because I couldn't get Circl…
Browse files Browse the repository at this point in the history
…eCI to play nice :(.
  • Loading branch information
ZviBaratz committed May 27, 2021
1 parent 2c78ac9 commit 9f9a9b6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ orbs:

jobs:
build-and-test:
version: 3.9
executor: python/default
working_directory: ~/dicom_parser
docker:
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,5 @@
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
],
)
5 changes: 2 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
envlist =
py37
py38
py39
cov_clean
cov_report
skipdist = true
Expand All @@ -14,8 +13,8 @@ deps =
coverage
factory-boy
depends =
{py37,py38,py39}: cov_clean
cov_report: py37,py38,py39
{py37,py38}: cov_clean
cov_report: py37,py38
commands =
coverage run -m pytest {toxinidir}/tests/

Expand Down

3 comments on commit 9f9a9b6

@nicolasperezdeo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Does this mean that there is no Python 3.9 support for the tool? I am facing issues trying to import the module in Python 3.9. Thank you!

@ZviBaratz
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolasperezdeo Python 3.9 is supported and the tests pass without any problems locally. This only refers to not having succeeded in making CircleCI use a test environment that has the 3.9 interpreter available.
What issues are you facing? Feel free to open a new issue.

@nicolasperezdeo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast answer. I see, will open an issue shortly.

Please sign in to comment.