forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: circuvent meilisearch bug with empty objects #695
Merged
navinkarkera
merged 17 commits into
navin/component-collection-api
from
rpenido/navin/component-collection-api-fix-meilisearch
Oct 11, 2024
Merged
fix: circuvent meilisearch bug with empty objects #695
navinkarkera
merged 17 commits into
navin/component-collection-api
from
rpenido/navin/component-collection-api-fix-meilisearch
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2024
ce7f906
to
3e889a9
Compare
The indexing update is already handled by m2m_changed handler.
3e889a9
to
cd9eec9
Compare
1debf71
to
baa10fc
Compare
Using `get_collection_components` does not work in case of post_remove as the component is already removed from collection and we don't really need additional filtering as we already have pk_set from the signal.
ccb2c54
to
6543313
Compare
6543313
to
758334f
Compare
4409ddc
to
bdee940
Compare
…onent-collection-api-fix-meilisearch
793e7bc
into
navin/component-collection-api
28 of 41 checks passed
navinkarkera
added a commit
that referenced
this pull request
Oct 12, 2024
…ction-api-fix-meilisearch fix: circuvent meilisearch bug with empty objects
navinkarkera
added a commit
that referenced
this pull request
Oct 15, 2024
…ction-api-fix-meilisearch fix: circuvent meilisearch bug with empty objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.