feat: Reintroduce Monitoring option using CDK Monitoring Constructs. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP screenshot of the first draft dashboard: |
|
Hi, any timeline for this PR? |
|
Currently got a bunch of work stuff to do, so will probably return to this one by the end of next week. Do you have any input on how the dashboard should look? |
…cs from all endpoint functions into common widgets
DerDackel
force-pushed
the
reintroduce-monitoring
branch
from
e72aa62 to
373de6c
Compare
…files the right way for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add the monitoring option from cdk-serverless v1. This implementation builds on the
cdk-monitoring-constructslibrary in hopes of keeping implementation effort for anything monitorting- and alerting-related low.There's a monitoring flag on the cdk-serverless' API constructs, but it currently does nothing.
A Cloudwatch dashboard with monitoring widgets for each API construct, including its endpoint Lambdas will be created if the monitoring flag is activated.
As cdk-monitoring-constructs currently requires at least aws-cdk v2.112.0, this will raise the minimum required CDK version on cdk-serverless.
Currently a rough draft, just to get something started as a discussion point on where to go. Not 100% sure about the usefulness of cdk-monitoring-constructs, I'm planning on evaluating it within the scope of this PR or return to a custom implementation if it proves not to be a good fit.
At the very least, I'd like to see the old Cloudwatch dashboard reconstructed. If possible, I want this to provide a base for an easy alerting abstraction over the API constructs, using Cloudwatch Alarms.