Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the verify error of logger. #177

Conversation

xuezhaojun
Copy link
Member

Fixes:

cmd/addon-agent/main.go:34:12: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
        logger := klogr.New()
                  ^
cmd/addon-manager/main.go:76:12: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
        logger := klogr.New()

Somehow the previous PR bypassed this check.

@openshift-ci openshift-ci bot requested review from qiujian16 and yue9944882 March 5, 2024 15:36
Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2024
@xuezhaojun
Copy link
Member Author

/assign @tamalsaha

Copy link

openshift-ci bot commented Mar 5, 2024

@xuezhaojun: GitHub didn't allow me to assign the following users: tamalsaha.

Note that only open-cluster-management-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @tamalsaha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tamalsaha
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Mar 5, 2024

@tamalsaha: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.86%. Comparing base (57e29d0) to head (78b5657).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   23.86%   23.86%           
=======================================
  Files           9        9           
  Lines        1194     1194           
=======================================
  Hits          285      285           
  Misses        892      892           
  Partials       17       17           
Flag Coverage Δ
unit 23.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/assign @skeeey

@skeeey
Copy link
Member

skeeey commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 635e1f5 into open-cluster-management-io:main Mar 6, 2024
9 checks passed
@xuezhaojun xuezhaojun deleted the fix-the-verifiy-error-of-logger branch March 6, 2024 02:12
openshift-merge-bot bot referenced this pull request in stolostron/cluster-proxy Mar 20, 2024
* Remove codecov token in actions. (#174)

Signed-off-by: xuezhaojun <[email protected]>

* Use k8s 1.29 client libs (#175)

Signed-off-by: Tamal Saha <[email protected]>

* Fix the verify error of logger. (#177)

Signed-off-by: GitHub <[email protected]>

* Upgrade chart version to 0.4.0. (#178)

Signed-off-by: GitHub <[email protected]>

* Update workflows. (#179)

Signed-off-by: GitHub <[email protected]>

* Simplify installer watchers (#180)

Signed-off-by: Tamal Saha <[email protected]>

* Remove unused code (#181)

Signed-off-by: Tamal Saha <[email protected]>

* Fix LB type proxy server setup in chart (#182)

Signed-off-by: Tamal Saha <[email protected]>

* Use default rollingout strategy. (#184)

Signed-off-by: GitHub <[email protected]>

* Add the hash value of signer into subject organizationunits (#183)

Signed-off-by: GitHub <[email protected]>

* Change examples to md format to reduce dependences. (#185)

Signed-off-by: GitHub <[email protected]>

* Update stolostronagent.

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: xuezhaojun <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Tamal Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants