-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the verify error of logger. #177
Fix the verify error of logger. #177
Conversation
Signed-off-by: GitHub <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @tamalsaha |
@xuezhaojun: GitHub didn't allow me to assign the following users: tamalsaha. Note that only open-cluster-management-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@tamalsaha: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 23.86% 23.86%
=======================================
Files 9 9
Lines 1194 1194
=======================================
Hits 285 285
Misses 892 892
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @skeeey |
/lgtm |
635e1f5
into
open-cluster-management-io:main
* Remove codecov token in actions. (#174) Signed-off-by: xuezhaojun <[email protected]> * Use k8s 1.29 client libs (#175) Signed-off-by: Tamal Saha <[email protected]> * Fix the verify error of logger. (#177) Signed-off-by: GitHub <[email protected]> * Upgrade chart version to 0.4.0. (#178) Signed-off-by: GitHub <[email protected]> * Update workflows. (#179) Signed-off-by: GitHub <[email protected]> * Simplify installer watchers (#180) Signed-off-by: Tamal Saha <[email protected]> * Remove unused code (#181) Signed-off-by: Tamal Saha <[email protected]> * Fix LB type proxy server setup in chart (#182) Signed-off-by: Tamal Saha <[email protected]> * Use default rollingout strategy. (#184) Signed-off-by: GitHub <[email protected]> * Add the hash value of signer into subject organizationunits (#183) Signed-off-by: GitHub <[email protected]> * Change examples to md format to reduce dependences. (#185) Signed-off-by: GitHub <[email protected]> * Update stolostronagent. Signed-off-by: GitHub <[email protected]> --------- Signed-off-by: xuezhaojun <[email protected]> Signed-off-by: Tamal Saha <[email protected]> Signed-off-by: GitHub <[email protected]> Co-authored-by: Tamal Saha <[email protected]>
Fixes:
Somehow the previous PR bypassed this check.