fix: Use OS DNS suffix when DNS suffix set in MEBx is empty-like #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsdmike
changed the title
rsdmike
approved these changes
Jan 15, 2025
Signed-off-by: Ben Krieger <[email protected]>
Bumps golang from `04ec561` to `c233391`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
ben-krieger
force-pushed
the
use-os-dns-suffix-when-mebx-is-whitespace
branch
from
4cdb6ed to
32bdb6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
===========================================
- Coverage 83.21% 62.12% -21.10%
===========================================
Files 32 45 +13
Lines 4265 5660 +1395
===========================================
- Hits 3549 3516 -33
- Misses 576 1854 +1278
- Partials 140 290 +150 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 2.42.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should the OS DNS suffix always be used when the DNS suffix set on AMT via MEBx is an invalid FQDN?
This change currently ignores whitespace and a trailing
.to allow "unsetting" in MEBx by setting the DNS suffix to either" "or"."(NOTE: cannot actually set to.in my version of MEBx).At least in my version of MEBx, setting to
""(an empty string) is not accepted.