[Feature] Added automated provisioning of CosmosDB and App Insights for OPEA applications - Infosys #657
Conversation
| indexing_mode = "consistent" | ||
|
|
||
| included_path { | ||
| path = "/*" |
There was a problem hiding this comment.
Does not /* cover everything? Is there some ordering effect here .. from most general to specific?
| name = "workspace-${var.cluster_name}" | ||
| location = azurerm_resource_group.main.location | ||
| resource_group_name = azurerm_resource_group.main.name | ||
| sku = "PerGB2018" |
There was a problem hiding this comment.
Do you really want to hard code sku or keep it a variable?
There was a problem hiding this comment.
sku is not what one might think. PerGB2018 is default, so we should leave it out for simplicity. If needed, we can add it later via variable.
|
@kkrishTa thanks for the PR. I think this is good addition. Few questions below. Can we make CosmosDB optional (opt-in)? User should have an option to include CosmosDB or leave it out. Do we have any OPEA apps using CosmosDB? |
|
@kkrishTa can you adress my questions above. I think we can merge this. |
Yes, We can make CosmosDB optional. Will update the code shortly. Apologies for late reply. |
| @@ -101,3 +101,8 @@ variable "throughput" { | |||
| error_message = "Cosmos db throughput should be in increments of 100." | |||
| } | |||
| } | |||
|
|
|||
| variable "is_cosmosdb_required" { | |||
There was a problem hiding this comment.
Can you add default (false) so use is not asked every time?
There was a problem hiding this comment.
Added and added one more parameter in tfvars also defaulted to false. Mentioned in README that users can update this if they want Cosmos DB as part of their provisioning.
|
LGTM |
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
|
Just FYI. v1.2rc branch is created minutes ago. If this PR is still targeted for v1.2, please set the milestone to v1.2, so Suyue can cherry-pick it to v1.2 rc branch later. |
@poussa Will you be able to do this? |
…or OPEA applications - Infosys (#657) * Updated terraform files with CosmosDB and App Insights Signed-off-by: kkrishTa <[email protected]> * Updating code with correct names Signed-off-by: kkrishTa <[email protected]> * correcting terraform Signed-off-by: kkrishTa <[email protected]> * Added opt in variable for cosmosdb provisioning Signed-off-by: kkrishTa <[email protected]> * Defaulting Cosmos DB provisioning to false and added variable in tfvars Signed-off-by: kkrishTa <[email protected]> --------- Signed-off-by: kkrishTa <[email protected]> (cherry picked from commit d29bd2d)
Description
Infosys contribution to OPEA.
Added CosmosDB and App Insights to the terraform on Azure.
Issues
NA
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Tested terraforms on Azure platform.