Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s deployment for neo4j #1254

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

jeanyu-habana
Copy link

Description

The purpose is to enable neo4j component to cover the installation and configuration in k8s env. This component will be a part of an end-to-end GenAI pipeline (named HybridRAG).

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

Tested the commands and configuration file (values.yaml) in k8s environment. Neo4j was properly installed and configured. Database was generated and can be accessed and updated from within the k8s environment, from command-line, and from the web console.

Signed-off-by: jeanyu-habana <[email protected]>
@letonghan
Copy link
Collaborator

Hi @jeanyu-habana, thanks for your contribution.
Please fix the ci test error of helm-test.

@letonghan letonghan mentioned this pull request Feb 7, 2025
4 tasks
@jeanyu-habana
Copy link
Author

jeanyu-habana commented Feb 10, 2025

Hi @jeanyu-habana, thanks for your contribution. Please fix the ci test error of helm-test.

fixed. @letonghan

@jeanyu-habana
Copy link
Author

Can I have at least one more approval from the reviewers? @XinyaoWa @lvliang-intel

@yongfengdu
Copy link
Collaborator

You are using the neo4j helm chart from upstream, and have customized values.yaml file.
In this case, we don't have to put it into our k8s deployment directory. You can refer to how we use milvus in dataprep:

Include the dependency in your HybridRAG dependency:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/Chart.yaml#L20
Then customize your values in your HybridRAG values file:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/milvus-values.yaml#L4

@jeanyu-habana
Copy link
Author

jeanyu-habana commented Feb 13, 2025

You are using the neo4j helm chart from upstream, and have customized values.yaml file. In this case, we don't have to put it into our k8s deployment directory. You can refer to how we use milvus in dataprep:

Include the dependency in your HybridRAG dependency: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/Chart.yaml#L20 Then customize your values in your HybridRAG values file: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/milvus-values.yaml#L4

Yes, this component can be used in our HybridRAG, but we have not decided if we will use neo4j or NebulaGraph in HybriRAG. The intent of this PR is to provide NebulaGraph as a general purpose microservice. HybridRAG is a work in progress, and we will reference the comment above as part of the HybridRAG dependency. However, in the context of this PR, do you think we can keep the content as is?
@yongfengdu

@yongfengdu
Copy link
Collaborator

The purpose of deployment/kubernetes directory is to put values file for testing our own helm charts (https://github.com/opea-project/GenAIInfra/tree/main/helm-charts).
The CI is also designed to fetch helm charts from here https://github.com/orgs/opea-project/packages.
I do not recommend put the neo4j readme here. It's confusing and will need to resolve CI issues.

You are using the neo4j helm chart from upstream, and have customized values.yaml file. In this case, we don't have to put it into our k8s deployment directory. You can refer to how we use milvus in dataprep:
Include the dependency in your HybridRAG dependency: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/Chart.yaml#L20 Then customize your values in your HybridRAG values file: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/data-prep/milvus-values.yaml#L4

Yes, this component can be used in our HybridRAG, but we have not decided if we will use neo4j or NebulaGraph in HybriRAG. The intent of this PR is to provide NebulaGraph as a general purpose microservice. HybridRAG is a work in progress, and we will reference the comment above as part of the HybridRAG dependency. However, in the context of this PR, do you think we can keep the content as is? @yongfengdu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants