Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): Operator Fee #10

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat(protocol): Operator Fee #10

merged 1 commit into from
Feb 4, 2025

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jan 8, 2025

Description

Defines L1BlockInfoIsthmus in maili-protocol to include the new operator fee scalar and operator fee constant.

Original PR in op-alloy: alloy-rs/op-alloy#130

Additional Context

Design Doc
Spec.

@refcell
Copy link
Contributor Author

refcell commented Jan 8, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from mattsse as a code owner January 8, 2025 18:42
@refcell refcell self-assigned this Jan 8, 2025
@refcell refcell requested review from emhane and clabby as code owners January 8, 2025 18:42
@refcell refcell added A-protocol Area: protocol crate C-feat Category: new feature or request C-hardfork labels Jan 8, 2025
@refcell refcell mentioned this pull request Jan 8, 2025
Closed
@emhane emhane added the C-blocked Category: cannot move forward until something else changes label Jan 8, 2025
@emhane
Copy link
Member

emhane commented Jan 8, 2025

blocked until spec is merged ethereum-optimism/specs#382

@refcell refcell marked this pull request as draft January 13, 2025 15:25
@refcell
Copy link
Contributor Author

refcell commented Jan 13, 2025

Aaaand back on ice

@emhane emhane removed the C-hardfork label Jan 15, 2025
@refcell refcell changed the title feat(protocol): Isthmus Operator Fee feat(protocol): Operator Fee Feb 2, 2025
@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 401e12c to d318194 Compare February 3, 2025 19:40
@refcell refcell marked this pull request as ready for review February 3, 2025 19:40
@refcell refcell removed the C-blocked Category: cannot move forward until something else changes label Feb 3, 2025
clabby
clabby approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me per the spec. Would be nice to get a double-check from the succinct team, but no need to block on it.

@refcell
Copy link
Contributor Author

refcell commented Feb 4, 2025

Network Upgrade Transactions (for posterity): alloy-rs/op-alloy#411

@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 7a8e500 to 966f4cc Compare February 4, 2025 12:01
@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 966f4cc to d9bb360 Compare February 4, 2025 12:04
@refcell refcell requested a review from leruaa February 4, 2025 12:05
leruaa
leruaa approved these changes Feb 4, 2025
View reviewed changes
Copy link

@leruaa leruaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refcell refcell merged commit e484275 into main Feb 4, 2025
21 checks passed
@refcell refcell deleted the rf/isthmus-operator-fee branch February 4, 2025 14:28
@leruaa leruaa mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leruaa leruaa leruaa approved these changes

@clabby clabby clabby approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@refcell refcell

Labels
A-protocol Area: protocol crate C-feat Category: new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refcell @emhane @leruaa @clabby