Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updated flavor definition to allow resource separation #634

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

aanorbel
Copy link
Member

Proposed Changes

  • Define flavorDimensions for provider where specific resources for ooni or dw can be placed.
  • Provide base strings in the main resources English where more languages can be added in the provider folders and supported languages added.
  • Move ooni specific translations to the right folder.

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I documented minor improvements and TODOs for me and you.

.github/workflows/build.yml Show resolved Hide resolved
app/build.gradle Outdated Show resolved Hide resolved
app/src/ooni/dev/readme.md Outdated Show resolved Hide resolved
app/src/dw/dev/google-services.json Show resolved Hide resolved
app/build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Small nitpick comment on the flavorDimension value, but otherwise LGTM 🐳

@aanorbel aanorbel requested a review from bassosimone November 27, 2023 07:30
@aanorbel aanorbel merged commit 50f9d4b into dw-media-probe Dec 5, 2023
5 checks passed
@aanorbel aanorbel deleted the chore/resource-separation branch December 5, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants