-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Updated flavor definition to allow resource separation #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I documented minor improvements and TODOs for me and you.
app/src/main/java/org/openobservatory/ooniprobe/common/PreferenceManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Small nitpick comment on the flavorDimension value, but otherwise LGTM 🐳
…nceManager.java Co-authored-by: Simone Basso <[email protected]>
…roid into chore/resource-separation
…hore/resource-separation
Proposed Changes
flavorDimensions
forprovider
where specific resources forooni
ordw
can be placed.English
where more languages can be added in the provider folders and supported languages added.ooni
specific translations to the right folder.