Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the x/net context in favour of the stdlib context #1492

Closed
wants to merge 2 commits into from

Conversation

tariq1890
Copy link
Contributor

This PR removes the usage of the golang.org/x/net package (which has a HIGH severity CVE) and replaces it with a stdlib package instead

@onsi
Copy link
Owner

onsi commented Dec 19, 2024

hey sorry - I had to force push to master to get rid of some accidentally committed test binaries. can you try to replace this diff on the latest master branch and make just the changes.

thanks btw - that x/net package has been a pain with CVEs. would love to stop depending on it.

belden and others added 2 commits December 18, 2024 22:40
I generated the _test.go.{csv,json} files by using a version of ginkgo
built from the next commit.

If tests are run on this sha, they are expected to fail; the next
commit fixes them.
@tariq1890
Copy link
Contributor Author

@onsi Sure, closing this PR in favour of this one #1493

@tariq1890 tariq1890 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants