Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #71 - size of overlay containing capture and convert icons to match parent size #72

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fixing #71 - size of overlay containing capture and convert icons to match parent size #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion peekaboo-ui/src/androidMain/kotlin/com/preat/peekaboo/ui/camera/PeekabooCamera.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import androidx.camera.core.Preview
import androidx.camera.lifecycle.ProcessCameraProvider
import androidx.camera.view.PreviewView
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.runtime.LaunchedEffect
Expand Down Expand Up @@ -69,6 +70,7 @@ actual fun PeekabooCamera(
modifier = modifier,
)
CompatOverlay(
modifier = Modifier.fillMaxSize(),
state = state,
captureIcon = captureIcon,
convertIcon = convertIcon,
Expand All @@ -79,12 +81,13 @@ actual fun PeekabooCamera(

@Composable
private fun CompatOverlay(
modifier: Modifier,
state: PeekabooCameraState,
captureIcon: @Composable (onClick: () -> Unit) -> Unit,
convertIcon: @Composable (onClick: () -> Unit) -> Unit,
progressIndicator: @Composable () -> Unit,
) {
Box {
Box(modifier = modifier) {
captureIcon(state::capture)
convertIcon(state::toggleCamera)
if (state.isCapturing) {
Expand Down