fix PeekabooCameraState recreation when lambda onCapture does not mem…

…oized
onseok · Mar 14, 2024 · 2a59de1 · 2a59de1
1 parent 5c2f5b4
commit 2a59de1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/...boo-ui/src/androidMain/kotlin/com/preat/peekaboo/ui/camera/PeekabooCameraState.android.kt b/...boo-ui/src/androidMain/kotlin/com/preat/peekaboo/ui/camera/PeekabooCameraState.android.kt
@@ -26,7 +26,7 @@ import androidx.compose.runtime.setValue
 @Stable
 actual class PeekabooCameraState(
     cameraMode: CameraMode,
-    private val onCapture: (ByteArray?) -> Unit,
+    internal var onCapture: (ByteArray?) -> Unit,
 ) {
     actual var isCameraReady: Boolean by mutableStateOf(false)
 
@@ -80,7 +80,8 @@ actual fun rememberPeekabooCameraState(
     onCapture: (ByteArray?) -> Unit,
 ): PeekabooCameraState {
     return rememberSaveable(
-        onCapture,
         saver = PeekabooCameraState.saver(onCapture),
-    ) { PeekabooCameraState(initialCameraMode, onCapture) }
+    ) { PeekabooCameraState(initialCameraMode, onCapture) }.apply {
+        this.onCapture = onCapture
+    }
 }
diff --git a/peekaboo-ui/src/iosMain/kotlin/com/preat/peekaboo/ui/camera/PeekabooCameraState.ios.kt b/peekaboo-ui/src/iosMain/kotlin/com/preat/peekaboo/ui/camera/PeekabooCameraState.ios.kt
@@ -26,7 +26,7 @@ import androidx.compose.runtime.setValue
 @Stable
 actual class PeekabooCameraState(
     cameraMode: CameraMode,
-    private val onCapture: (ByteArray?) -> Unit,
+    internal var onCapture: (ByteArray?) -> Unit,
 ) {
     actual var isCameraReady: Boolean by mutableStateOf(false)
 
@@ -80,7 +80,8 @@ actual fun rememberPeekabooCameraState(
     onCapture: (ByteArray?) -> Unit,
 ): PeekabooCameraState {
     return rememberSaveable(
-        onCapture,
         saver = PeekabooCameraState.saver(onCapture),
-    ) { PeekabooCameraState(initialCameraMode, onCapture) }
+    ) { PeekabooCameraState(initialCameraMode, onCapture) }.apply {
+        this.onCapture = onCapture
+    }
 }