relax dependency requirements, add rails 6.1 support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem does not actually depend on i18n being <1. There is a PR onomojo#33 that just changes the version. This suggests that the code works with i18n >1. The gemspec should allow that. Also, older country translations is also supported. They were upgraded in onomojo#30 because of security concerns, without any code changes. Bundler warns and advises for security. This gem should not force people to upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n country select dependency
i18n ~> 0.9.3means this gem allows i18n versions>= 0.9.3and< 1.0.0This makes it incompatible with rails 6.1, as they require
i18n >= 1.6I believe the intention should be just
>= 0.9.3.The gem does not actually depend on i18n being <1. There is a PR #33 that just changes the version. This suggests that the code works with i18n >1. The gemspec should allow that.
Also, older country translations is also supported. They were upgraded in #30 because of security concerns, without any code changes. Bundler warns and advises for security. This gem should not force people to upgrade.