Update NPM Packages #583
Closed
Update NPM Packages #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 24, 2019 10:18
(130) _ ~/.../js/nexchange-open-client-react
% parcel build src/index.js (feature/implement-parcel)
🚨 /home/_/dev/js/nexchange-open-client-react/src/index.js: Cannot resolve dependency '/home/_/dev/js/nexchange-open-client-react/node_modules/@babel/runtime/helpers/esm/extends' at '/home/_/dev/js/nexchange-open-client-react/node_modules/@babel/runtime/helpers/esm/extends'
at Resolver.resolve (/home/_/.npm/lib/node_modules/parcel-bundler/src/Resolver.js:71:17)
Double checked this, before uninstalling them with the following command: npm uninstall start-server-and-test react-test-renderer jest-mock-axios jest-localstorage-mock @storybook/addons @storybook/addon-links webpack-dev-middleware reactstrap react-svg-inline react-loadable js-yaml expose-loader @babel/runtime-corejs2
As suggested here oasislabs/web3c.js#93
|
Until the final commit 26bc4b5 with updated snapshots, tests are failing. I manually diffed these snapshots and they look OK to me but haven't double checked what these changes enzyme have made are. I manually tested too, but not the entire app. |
|
Have looked at Travis CI build failures but they look like the errors that "normally occur". |
|
Deferred by @BeOleg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've broken down my changes into a series of commits, to re-state what each does:
npm updatenpm audit fixnvx npm-check) - I attempted to double-check these were indeed unused, too by searching the codebase for mention of the packages (and didn't follow every recommendation).I've subsequently clicked around the site and things appear to be working (at least in Chrome, on my machine...).
However, am quite happy to have this rejected - maybe my methodology (or some part of my methodology) around updating packages is wrong? Specifically:
Although both npm nor npm-check claim that the changes they'll have made will be non-breaking only, I don't know to what extent that can be relied upon.