Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Malleability] cluster.Block type ID method malleable. #6983

Conversation

AndriiDiachuk
Copy link
Contributor

@AndriiDiachuk AndriiDiachuk commented Feb 5, 2025

closes: #6660

Context

This PR fixes the implementation of the ID() method for the cluster.Block type to cover all fields as it's used through the codebase.
Changes have no impact on tests.

Not for review yet.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (91bef99) to head (eaf42c9).

Files with missing lines Patch % Lines
model/cluster/block.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/malleability    #6983      +/-   ##
========================================================
+ Coverage                 41.15%   43.77%   +2.62%     
========================================================
  Files                      2122     1033    -1089     
  Lines                    187214    96735   -90479     
========================================================
- Hits                      77055    42350   -34705     
+ Misses                   103718    50988   -52730     
+ Partials                   6441     3397    -3044     
Flag Coverage Δ
unittests 43.77% <0.00%> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriiDiachuk
Copy link
Contributor Author

The current type will be moved to Malleability C as it's similar to the flow.Block type and will need a bigger scope of changes.

@AndriiDiachuk AndriiDiachuk deleted the andrii/6660-cluster-block-malleability branch February 6, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants