Merge pull request #581 from onflow/jribbink/staged-contracts

onflow · Feb 26, 2024 · e3ecdca · e3ecdca
2 parents 08ab56f + a96827e
commit e3ecdca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/storage/migration/cadence1.go b/storage/migration/cadence1.go
@@ -31,6 +31,7 @@ import (
 
 func MigrateCadence1(
 	store *sqlite.Store,
+	stagedContracts []migrations.StagedContract,
 	rwf reporters.ReportWriterFactory,
 	logger zerolog.Logger,
 ) error {
@@ -46,9 +47,6 @@ func MigrateCadence1(
 	// TODO: EVM contract is not deployed in snapshot yet, so can't update it
 	const evmContractChange = migrations.EVMContractChangeNone
 
-	// TODO:
-	var stagedContracts []migrations.StagedContract
-
 	cadence1Migrations := migrations.NewCadence1Migrations(
 		logger,
 		rwf,

diff --git a/storage/migration/cadence1_test.go b/storage/migration/cadence1_test.go
@@ -59,7 +59,7 @@ func TestCadence1Migration(t *testing.T) {
 
 	// Then migrate the values.
 	rwf := &NOOPReportWriterFactory{}
-	err = MigrateCadence1(store, rwf, logger)
+	err = MigrateCadence1(store, nil, rwf, logger)
 	require.NoError(t, err)
 
 	require.Empty(t, logWriter.logs)