Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarak/fix crypto build #1379

Closed
wants to merge 10 commits into from
Closed

Tarak/fix crypto build #1379

wants to merge 10 commits into from

Conversation

tarakby
Copy link

@tarakby tarakby commented Feb 5, 2024

Closes #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b05ee6f) 40.49% compared to head (aed4276) 40.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   40.49%   40.49%           
=======================================
  Files          47       47           
  Lines        2588     2588           
=======================================
  Hits         1048     1048           
  Misses       1416     1416           
  Partials      124      124           
Flag Coverage Δ
unittests 40.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby force-pushed the tarak/fix-crypto-build branch from b5aebbd to 0d56b35 Compare February 5, 2024 19:27
@tarakby tarakby force-pushed the tarak/fix-crypto-build branch from aed4276 to 1458d88 Compare February 7, 2024 14:30
@tarakby
Copy link
Author

tarakby commented Feb 23, 2024

closing the PR against master as #1423 is addressing the issue in the stable cadence branch

@tarakby tarakby closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants