Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cadence 1.0 support #1355

Merged
merged 362 commits into from
Jun 20, 2024
Merged

Cadence 1.0 support #1355

merged 362 commits into from
Jun 20, 2024

Conversation

ianthpun
Copy link
Contributor

Closes #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 40.42989% with 1164 lines in your changes missing coverage. Please review.

Project coverage is 33.80%. Comparing base (78a6b22) to head (649120d).
Report is 148 commits behind head on master.

Files Patch % Lines
internal/super/setup.go 0.00% 173 Missing ⚠️
internal/migrate/stage.go 20.39% 111 Missing and 10 partials ⚠️
internal/migrate/staging_validator.go 64.88% 98 Missing and 20 partials ⚠️
internal/super/scaffolds.go 0.00% 85 Missing ⚠️
internal/command/command.go 0.00% 57 Missing ⚠️
internal/prompt/select-options.go 0.00% 53 Missing ⚠️
internal/migrate/is_validated.go 3.77% 51 Missing ⚠️
internal/evm/gateway.go 0.00% 48 Missing ⚠️
internal/migrate/state.go 37.14% 38 Missing and 6 partials ⚠️
internal/migrate/validator/validator.go 73.15% 26 Missing and 14 partials ⚠️
... and 37 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
- Coverage   39.99%   33.80%   -6.20%     
==========================================
  Files          51      100      +49     
  Lines        3313     6331    +3018     
==========================================
+ Hits         1325     2140     +815     
- Misses       1819     3902    +2083     
- Partials      169      289     +120     
Flag Coverage Δ
unittests 33.80% <40.42%> (-6.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent marked this pull request as ready for review June 18, 2024 20:59
@turbolent turbolent changed the title Feature/stable cadence Cadence 1.0 support Jun 18, 2024
@turbolent turbolent merged commit b6c8838 into master Jun 20, 2024
8 checks passed
@turbolent turbolent deleted the feature/stable-cadence branch June 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.