Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial unit tests for global flags #1340

Merged
merged 4 commits into from
Jan 24, 2024
Merged

add initial unit tests for global flags #1340

merged 4 commits into from
Jan 24, 2024

Conversation

ianthpun
Copy link
Contributor

@ianthpun ianthpun commented Jan 11, 2024 •
edited
Loading

Closes #1276

Description

i wanted to reorganize a few more files, but the lift would be quite heavy as global flag functions are quite coupled at the moment. This will atleast set a standard of any new global flags added to make sure it is correctly initialized.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@ianthpun ianthpun changed the title add initial unit tests add initial unit tests for global flags Jan 11, 2024
@ianthpun ianthpun marked this pull request as ready for review January 17, 2024 20:24
bthaile
bthaile approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the simplicity, lgtm

@ianthpun ianthpun merged commit 64cc226 into master Jan 24, 2024
6 checks passed
@ianthpun ianthpun deleted the ianthpun/unit-test-fixes branch January 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@bthaile bthaile bthaile approved these changes

@chasefleming chasefleming chasefleming approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@sideninja sideninja Awaiting requested review from sideninja

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unit tests for flags and options
4 participants
@ianthpun @chasefleming @bthaile @janezpodhostnik