Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use assert.Contains for result.OneLiner() check to fix flaky test #1304

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ianthpun
Copy link
Contributor

@ianthpun ianthpun commented Dec 13, 2023

Closes #???

Description

use assert.Contains for result.OneLiner() check to fix flaky test, as sometimes it would run out of order


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfc51e9) 39.93% compared to head (cce9976) 39.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   39.93%   39.93%           
=======================================
  Files          39       39           
  Lines        2161     2161           
=======================================
  Hits          863      863           
  Misses       1203     1203           
  Partials       95       95           
Flag Coverage Δ
unittests 39.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ianthpun ianthpun merged commit d910d27 into master Dec 13, 2023
5 checks passed
@ianthpun ianthpun deleted the ianthpun/flaky-test-fix branch December 13, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants