Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Account Manager Race Condition #2102

Closed
wants to merge 11 commits into from
Closed

Address Account Manager Race Condition #2102

wants to merge 11 commits into from

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 2, 2025 •
edited
Loading

Address a race condition where the account manager does not wait for the chainId to finish loading before propogating.

@jribbink jribbink requested a review from a team as a code owner February 2, 2025 00:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dcbb13f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the base branch from master to jribbink/chain-changed February 2, 2025 00:10
@jribbink jribbink marked this pull request as draft February 2, 2025 00:12
Base automatically changed from jribbink/chain-changed to feature/cross-vm February 3, 2025 21:08
@jribbink jribbink force-pushed the jribbink/account-manager-race branch from da776af to 5bf99b1 Compare February 3, 2025 22:01
@jribbink jribbink marked this pull request as ready for review February 5, 2025 22:53
@jribbink jribbink marked this pull request as draft February 5, 2025 23:23
@jribbink jribbink closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming