Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKG -- [sdk] Misc Typescript Fixes #1918

Merged
merged 2 commits into from
Jul 12, 2024
Merged

PKG -- [sdk] Misc Typescript Fixes #1918

merged 2 commits into from
Jul 12, 2024

Conversation

jribbink
Copy link
Contributor

Closes #1917

@jribbink jribbink requested a review from a team as a code owner July 12, 2024 20:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d8dbbb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@onflow/typedefs Patch
@onflow/sdk Patch
@onflow/fcl-core Patch
@onflow/fcl-react-native Patch
@onflow/fcl Patch
@onflow/fcl-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink marked this pull request as draft July 12, 2024 20:21
@jribbink
Copy link
Contributor Author

Build failing... investigating.

@jribbink jribbink marked this pull request as ready for review July 12, 2024 20:45
nialexsan
nialexsan approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bthaile
bthaile approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jribbink jribbink merged commit bc78da0 into master Jul 12, 2024
1 check passed
@jribbink jribbink deleted the jribbink/ts-fixes branch July 12, 2024 21:57
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsantos gregsantos gregsantos approved these changes

@bthaile bthaile bthaile approved these changes

@nialexsan nialexsan nialexsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK Typescript issues
4 participants
@jribbink @gregsantos @bthaile @nialexsan