PKG -- [fcl-core] Remove unnecessary config overload #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8eca819 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
force-pushed
the
jribbink/fix-wc-error
branch
from
539fdec to
8eca819
Compare
jribbink
changed the title
nialexsan
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1913
This
config.overloadcall is never used becauseprepTemplateOptsactually generates the Cadence code itself from the tempalte anyways (i.e. this operation is not handled by conventional FCL import replacement from config).Not sure if this is something old that slipped through and was just never used, or what the case here.
More broadly though, we should not be modifying the configuration object internally. It should serve as user configuration & we should try to avoid using it as global state. Particularly,
config.overloadcan be deceiving as it executes an async function, meaning that when the inner function yields control to the event loop it could mean that this overloaded config can leak into another execution context (i.e. via this shared global state).