Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Typescript issues #1917

Closed
jribbink opened this issue Jul 10, 2024 · 0 comments · Fixed by #1918
Closed

SDK Typescript issues #1917

jribbink opened this issue Jul 10, 2024 · 0 comments · Fixed by #1918
Assignees
@jribbink
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

User reported typescript inconsistences with fcl.send & fcl.encode

see: https://discord.com/channels/613813861610684416/621847426201944074/1260361361242718240

for example - fcl|sdk.send accepts either a single object or an array of objects - ts allows only array
other example - sdk.encode - typescript typing defines computeLimit as string, while the validator asserts it is a number...
@jribbink jribbink added the Bug Something isn't working label Jul 10, 2024
@jribbink jribbink self-assigned this Jul 10, 2024
@jribbink jribbink moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Jul 10, 2024
@jribbink jribbink mentioned this issue Jul 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready for Pickup to ✅ Done in 🌊 Flow 4D Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jribbink jribbink

Labels
Bug Something isn't working
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PKG -- [sdk] Misc Typescript Fixes onflow/fcl-js
1 participant
@jribbink