Move configuration to a single context #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #191
Currently, configuration (i.e. that received from FCL via WalletUtils & that derived from query parameters) is not managed as any sort of global state.
It is either passed passed through props OR (in the case of WalletUtils) requested from the client FCL instance in many places as needed.
This presents a few issues for the planned v2 expansion to FCL Discovery (which I have ran into trying to implement these changes)
useFCL
hook is called. Not inherently bad, but shared state would allow us to only query this once and reuse it throughout the app.useWallets
hook, which is necessary as multiple components need access to this API call). This again necessitates prop drilling and instantiating state at a much higher level in the application than where it is used.