Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ViewResolver deployment #427

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Remove ViewResolver deployment #427

merged 2 commits into from
Oct 30, 2023

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Oct 30, 2023 •
edited
Loading

Scaffold now includes ViewResolver so we no longer need this section.

Issue: #429

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 10:39pm

gregsantos
gregsantos approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀
Found a typo on 721, might could resolve in this PR:

Finally, we need a way to get read this data like we did with the NFT

@chasefleming
Copy link
Member Author

Fixed

@chasefleming chasefleming merged commit 5049361 into main Oct 30, 2023
2 checks passed
@chasefleming chasefleming deleted the chasefleming/remove-view-resolver-deployment branch October 30, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsantos gregsantos gregsantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chasefleming @gregsantos