Cancel moved to avoid crash

onevcat · Sep 28, 2020 · 96ed421 · 96ed421
1 parent 6444118
commit 96ed421
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/Sources/Networking/SessionDataTask.swift b/Sources/Networking/SessionDataTask.swift
@@ -101,9 +101,6 @@ public class SessionDataTask {
         guard let callback = removeCallback(token) else {
             return
         }
-        if callbacksStore.count == 0 {
-            task.cancel()
-        }
         onCallbackCancelled.call((token, callback))
     }
 

diff --git a/Sources/Networking/SessionDelegate.swift b/Sources/Networking/SessionDelegate.swift
@@ -72,6 +72,7 @@ class SessionDelegate: NSObject {
             // No other callbacks waiting, we can clear the task now.
             if !task.containsCallbacks {
                 let dataTask = task.task
+                dataTask.cancel()
                 self.remove(dataTask)
             }
         }